Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewording notification message + simplifying notification logic #3

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Rewording notification message + simplifying notification logic #3

merged 2 commits into from
Sep 11, 2024

Conversation

gonimoro
Copy link

@gonimoro gonimoro commented Sep 9, 2024

Summary

Simplifying notification message and removing memory warning threshold status calculation.

@gonimoro gonimoro requested a review from a team as a code owner September 9, 2024 16:11
@gonimoro gonimoro assigned enolfc and unassigned enolfc Sep 9, 2024
@gonimoro gonimoro requested a review from enolfc September 9, 2024 16:23
enolfc
enolfc approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enolfc
Copy link
Contributor

enolfc commented Sep 10, 2024

Can you fix the linting issues?

@enolfc enolfc added the enhancement New feature or request label Sep 10, 2024
@gonimoro
Copy link
Author

Fixed

@enolfc enolfc merged commit 86e1599 into EGI-Federation:main Sep 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enolfc enolfc enolfc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonimoro @enolfc